Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): filter out localhost when identify notifies kademlia #468

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

ShahakShama
Copy link
Contributor

@ShahakShama ShahakShama commented Aug 15, 2024

This change is Reviewable

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.79%. Comparing base (bc4fc7d) to head (618628b).
Report is 7 commits behind head on main.

Files Patch % Lines
crates/papyrus_network/src/discovery/kad_impl.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   76.75%   76.79%   +0.04%     
==========================================
  Files         348      348              
  Lines       36384    36297      -87     
  Branches    36384    36297      -87     
==========================================
- Hits        27926    27875      -51     
+ Misses       6135     6127       -8     
+ Partials     2323     2295      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eitanm-starkware eitanm-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AlonLStarkWare)

@eitanm-starkware eitanm-starkware force-pushed the shahak/identify_no_external branch from fccb9b7 to 618628b Compare August 18, 2024 13:57
@eitanm-starkware eitanm-starkware merged commit 6d48a42 into main Aug 18, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants