-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockifier): add versioned constant file for v0.13.2 #464
chore(blockifier): add versioned constant file for v0.13.2 #464
Conversation
860e378
to
35b924e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
- Coverage 76.62% 76.61% -0.01%
==========================================
Files 346 346
Lines 36263 36269 +6
Branches 36263 36269 +6
==========================================
+ Hits 27786 27788 +2
- Misses 6175 6178 +3
- Partials 2302 2303 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
crates/papyrus_execution/src/lib.rs
line 91 at r1 (raw file):
const STARKNET_VERSION_O_13_0: &str = "0.13.0"; const STARKNET_VERSION_O_13_1: &str = "0.13.1";
@eitanm-starkware : why don't we have here 0.13.1.1
?
Consider using this getter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware)
crates/papyrus_execution/src/lib.rs
line 91 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
@eitanm-starkware : why don't we have here
0.13.1.1
?
Consider using this getter.
The StarknetVersion that the getter expects and the StarknetVersion that the function gets are not the same type.
So I am not sure how to use this getter there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
crates/papyrus_execution/src/lib.rs
line 91 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
The StarknetVersion that the getter expects and the StarknetVersion that the function gets are not the same type.
So I am not sure how to use this getter there.
You are right. Maybe now we should consider unifying it (not relevant to this PR)
This change is