Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): add versioned constant file for v0.13.2 #464

Merged

Conversation

meship-starkware
Copy link
Contributor

@meship-starkware meship-starkware commented Aug 14, 2024

This change is Reviewable

@meship-starkware meship-starkware force-pushed the meship/blockifier/add_versioned_constant_for_0_13_2 branch from 860e378 to 35b924e Compare August 14, 2024 13:44
@meship-starkware meship-starkware changed the title chore(bockifier): add versioned constant file for v0.13.2 chore(blockifier): add versioned constant file for v0.13.2 Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.61%. Comparing base (13ae058) to head (35b924e).
Report is 12 commits behind head on main.

Files Patch % Lines
crates/papyrus_execution/src/lib.rs 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   76.62%   76.61%   -0.01%     
==========================================
  Files         346      346              
  Lines       36263    36269       +6     
  Branches    36263    36269       +6     
==========================================
+ Hits        27786    27788       +2     
- Misses       6175     6178       +3     
- Partials     2302     2303       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)


crates/papyrus_execution/src/lib.rs line 91 at r1 (raw file):

const STARKNET_VERSION_O_13_0: &str = "0.13.0";
const STARKNET_VERSION_O_13_1: &str = "0.13.1";

@eitanm-starkware : why don't we have here 0.13.1.1?
Consider using this getter.

Copy link
Contributor Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware)


crates/papyrus_execution/src/lib.rs line 91 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

@eitanm-starkware : why don't we have here 0.13.1.1?
Consider using this getter.

The StarknetVersion that the getter expects and the StarknetVersion that the function gets are not the same type.
So I am not sure how to use this getter there.

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)


crates/papyrus_execution/src/lib.rs line 91 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

The StarknetVersion that the getter expects and the StarknetVersion that the function gets are not the same type.
So I am not sure how to use this getter there.

You are right. Maybe now we should consider unifying it (not relevant to this PR)

@meship-starkware meship-starkware merged commit 4b89e22 into main Aug 18, 2024
43 of 45 checks passed
@meship-starkware meship-starkware deleted the meship/blockifier/add_versioned_constant_for_0_13_2 branch August 18, 2024 05:22
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants