Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(fee): add events to l2 cost #462

Closed

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Aug 14, 2024

This change is Reviewable

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.85%. Comparing base (d3c34bb) to head (cb958fb).

Files with missing lines Patch % Lines
crates/blockifier/src/transaction/objects.rs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           nimrod/l2_gas/code_cost     #462      +/-   ##
===========================================================
- Coverage                    70.86%   70.85%   -0.02%     
===========================================================
  Files                           85       85              
  Lines                        11020    11016       -4     
  Branches                     11020    11016       -4     
===========================================================
- Hits                          7809     7805       -4     
+ Misses                        2821     2820       -1     
- Partials                       390      391       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/code_cost branch from 0e4321b to d4616c2 Compare August 28, 2024 13:22
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from 6949bc1 to fc82229 Compare August 28, 2024 13:22
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from fc82229 to 28b3e11 Compare September 1, 2024 05:32
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from 28b3e11 to 6eaca26 Compare September 1, 2024 06:00
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from 6eaca26 to 9326133 Compare September 1, 2024 08:17
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from 9326133 to 2459227 Compare September 1, 2024 11:00
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from 2459227 to d4aa64b Compare September 3, 2024 06:45
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from d4aa64b to 976e2a1 Compare September 3, 2024 13:43
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from 976e2a1 to 5bb60c1 Compare September 3, 2024 13:46
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from 5bb60c1 to 1af1e25 Compare September 3, 2024 13:52
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from 1af1e25 to f77c0d3 Compare September 3, 2024 15:18
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from f77c0d3 to 4aefa52 Compare September 4, 2024 06:40
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from 4aefa52 to dd55c0d Compare September 4, 2024 07:05
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from dd55c0d to a370b17 Compare September 4, 2024 11:08
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from a370b17 to babb442 Compare September 4, 2024 11:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from babb442 to f7db3eb Compare September 4, 2024 13:39
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from f7db3eb to d60b9d1 Compare September 5, 2024 07:18
@nimrod-starkware nimrod-starkware force-pushed the nimrod/l2_gas/events_cost branch from d60b9d1 to cb958fb Compare September 5, 2024 11:11
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant