Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve blockifier CI trigger and scope #41

Closed
wants to merge 28 commits into from

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Jul 24, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

dafnamatsry and others added 27 commits May 2, 2024 14:06
fix(format): run format fix on all repo
* feature(ci): Identify which package need to be built according to file changed
---------

Signed-off-by: Dori Medini <[email protected]>
Co-authored-by: Dori Medini <[email protected]>
* chore: fix ci to always compare changes against the target branch
* chore: copy all crates

* chore: switch to local dependencies

* chore: delete old papyrus_test_utils crate

* chore: rename crate test_utils -> papyrus_test_utils

* chore: fix RPCTransactio name in the mempool

* chore: fix mockito deps in papyrus and gateway

* chore: update cairo-* deps version

* chore: update config and presets for mempool and papyrus

* chore: rename default_config.json -> papyrus_default_config.json

* chore: rustfmt

* chore: reorg folders

* chore: reorg folders

* chore: fix unused deps

* chore: update papyrus Dockerfile

* chore: update scripts folder

* chore: copy build_native_blockifier.sh

* chore: copy BUILD and WORKSPACE files (from blockifier and committer)

* chore: update papyrus non crates folders and files

* chore: copy blockifier docs

* chore: copy committer taplo.toml

* chore: fix config tests

* chore: copy blockifier docker file

* fix: papyrus integration test runs only Papyrus related tests

* chore: rename conflicting dump_config.rs files

* chore: fix cargo doc errors

* chore: fix CI

* chore: small optimizations for the papyrus CI

* chore: copy README files

* chore: meld common repo files

---------

Co-authored-by: alon.dotan <[email protected]>
Co-authored-by: Dan Brownstein <[email protected]>
Signed-off-by: Dori Medini <[email protected]>
@dorimedini-starkware dorimedini-starkware changed the base branch from main to main-v0.13.2 July 24, 2024 07:34
@dorimedini-starkware dorimedini-starkware changed the title Dori/improve blockifier ci chore: improve blockifier CI trigger and scope Jul 24, 2024
@dorimedini-starkware dorimedini-starkware force-pushed the dori/improve-blockifier-ci branch from 66ac397 to d543d13 Compare July 24, 2024 07:56
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @noaov1)


.github/workflows/blockifier_post-merge.yml line 35 at r1 (raw file):

      - run: |
          pip install -r crates/blockifier/tests/requirements.txt
          cargo test -p blockifier -p native_blockifier -- --include-ignored

previously, this job would run tests on all crates on post-merge

Code quote:

cargo test -p blockifier -p native_blockifier -- --include-ignored

@dorimedini-starkware dorimedini-starkware force-pushed the dori/improve-blockifier-ci branch from d543d13 to 4ad2acf Compare July 24, 2024 09:13
@liorgold2 liorgold2 closed this Jul 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants