build(blockifier, fee): translate resources to l2 gas #384
Conversation
nimrod-starkware
force-pushed
the
nimrod/add_l2_gas_to_gas_vector/adjust_conversion
branch
from
0889b2d to
c203584
Compare
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @TzahiTaub)
crates/blockifier/src/fee/fee_test.rs line 38 at r1 (raw file):
#[test] fn test_simple_calculate_l1_gas_by_vm_usage() {
for backwards-compatibility we need the L1 gas computation to (a) still exist and (b) be consistent with the (new) L2 gas computation, right?
you are changing the old tests to no longer test L1 gas computation...?
please parametrize the tests instead
There was a problem hiding this comment.
Reviewed 1 of 5 files at r1, all commit messages.
Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)
crates/blockifier/src/transaction/objects.rs line 177 at r1 (raw file):
l1_gas: gas_vector.l1_gas + gas_vector.l2_gas, l1_data_gas: gas_vector.l1_data_gas, l2_gas: 0,
How does this work if the struct doesn't have it?
Code quote:
l2_gas: 0,There was a problem hiding this comment.
Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on @TzahiTaub)
crates/blockifier/src/transaction/objects.rs line 177 at r1 (raw file):
Previously, TzahiTaub (Tzahi) wrote…
How does this work if the struct doesn't have it?
it does have it. always 0, unused
There was a problem hiding this comment.
Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)
crates/blockifier/src/transaction/objects.rs line 177 at r1 (raw file):
Previously, nimrod-starkware wrote…
it does have it. always 0, unused
I think I have some reviewable bug
This change is