chore(blockifier): add resource bounds to faulty account transaction creator

[meship-starkware]

This change is 

[noaov1]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @meship-starkware)

---

crates/blockifier/src/blockifier/stateful_validator_test.rs line 50 at r1 (raw file):

    // TODO(Arni, 1/5/2024): Cover resource bounds in version 3 txs. Test the validator validate
    // enough "fee" in version 3 txs.

Can be removed, no?

Code quote:

    // TODO(Arni, 1/5/2024): Cover resource bounds in version 3 txs. Test the validator validate
    // enough "fee" in version 3 txs.

---

crates/blockifier/src/blockifier/stateful_validator_test.rs line 57 at r1 (raw file):

        class_hash,
        validate_constructor,
        // TODO(Arni, 1/5/2024): Add test for insufficient max fee.

Suggestion:

// TODO(Arni, 1/5/2024): Add test for insufficient maximal resources..

---

crates/blockifier/src/blockifier/stateful_validator_test.rs line 74 at r1 (raw file):

    let charge_fee = false;
    let skip_validation = false;
    let result = stateful_validator.perform_validations(tx, skip_validation, charge_fee);

Please restore

Code quote:

    let charge_fee = false;
    let skip_validation = false;
    let result = stateful_validator.perform_validations(tx, skip_validation, charge_fee);

---

crates/blockifier/src/blockifier/stateful_validator_test.rs line 92 at r1 (raw file):

        sender_address: faulty_account.get_instance_address(0),
        class_hash: faulty_account.get_class_hash(),
        max_fee: Fee(BALANCE),

Suggestion:

        tx_version: TransactionVersion::THREE,
        sender_address: faulty_account.get_instance_address(0),
        class_hash: faulty_account.get_class_hash(),

---

crates/blockifier/src/transaction/transactions_test.rs line 1557 at r1 (raw file):

        contract_address_salt: salt_manager.next_salt(),
        resource_bounds: default_testing_resource_bounds(),
        ..default_args

As it is defined in the default args :)
Same below

Suggestion:

        ..default_args

[noaov1]

Nice catch!

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @meship-starkware)

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.754 ms 65.470 ms 66.796 ms]
change: [-8.6072% -5.0535% -1.5491%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
6 (6.00%) high mild
3 (3.00%) high severe

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.42%. Comparing base (cd9fcf5) to head (07cee6a).
Report is 11 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   76.42%   76.42%           
=======================================
  Files         349      349           
  Lines       36936    36939    +3     
  Branches    36936    36939    +3     
=======================================
+ Hits        28228    28231    +3     
- Misses       6383     6384    +1     
+ Partials     2325     2324    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[meship-starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @noaov1)

---

crates/blockifier/src/blockifier/stateful_validator_test.rs line 50 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Can be removed, no?

Done.

---

crates/blockifier/src/transaction/transactions_test.rs line 1557 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

As it is defined in the default args :)
Same below

This does not work because reasource_boundes does not implement copy.
Will be solved soon after nimrod will finish with his PRs. Would you like me to add a TODO?

[noaov1]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)