Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename max_raw_casm_class_size to max_casm_contract_class_object_size #354

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 7, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Aug 7, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware marked this pull request as ready for review August 7, 2024 12:08
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 7225149 to f75f21d Compare August 7, 2024 12:53
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from 3531483 to d172ab0 Compare August 7, 2024 12:53
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from f75f21d to ff40115 Compare August 7, 2024 13:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from d172ab0 to 314fa55 Compare August 7, 2024 13:06
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from ff40115 to 367216a Compare August 8, 2024 10:05
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from 314fa55 to bbd7fb7 Compare August 8, 2024 10:05
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 367216a to feb96da Compare August 8, 2024 11:14
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from bbd7fb7 to b609eea Compare August 8, 2024 11:15
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from feb96da to f7d4f8e Compare August 8, 2024 12:05
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from b609eea to e6d424d Compare August 8, 2024 12:05
@ArniStarkware ArniStarkware mentioned this pull request Aug 8, 2024
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from f7d4f8e to 1354412 Compare August 11, 2024 08:07
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from e6d424d to d4d38be Compare August 11, 2024 08:07
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 1354412 to eeb7ac1 Compare August 11, 2024 08:17
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from d4d38be to c8cbd4f Compare August 11, 2024 08:17
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from eeb7ac1 to 976f8fb Compare August 12, 2024 07:20
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from c8cbd4f to f2e4797 Compare August 12, 2024 07:20
@ArniStarkware ArniStarkware force-pushed the arni/declare/post_compilation/size_validation branch from 976f8fb to ff67b95 Compare August 12, 2024 07:43
@ArniStarkware ArniStarkware force-pushed the arni/declare/validation/rename_total_size_validation branch from f2e4797 to 9547f5d Compare August 12, 2024 07:43
Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 12, 2024
@github-actions github-actions bot closed this Sep 19, 2024
@ArniStarkware ArniStarkware reopened this Sep 19, 2024
@ArniStarkware
Copy link
Contributor Author

Will be squashed into parent PR.

@ArniStarkware ArniStarkware deleted the arni/declare/validation/rename_total_size_validation branch September 25, 2024 08:28
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants