Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): make rust version in ci configurable #349

Closed
wants to merge 1 commit into from

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Aug 7, 2024

This change is Reviewable

@nimrod-starkware nimrod-starkware self-assigned this Aug 7, 2024
@nimrod-starkware nimrod-starkware force-pushed the nimrod/rust_version_fix branch 5 times, most recently from 9d6ff98 to 38c0b46 Compare August 7, 2024 10:35
Copy link

github-actions bot commented Aug 7, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.692 ms 65.811 ms 65.975 ms]
change: [-8.0871% -4.3987% -1.3239%] (p = 0.01 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

@nimrod-starkware nimrod-starkware force-pushed the nimrod/rust_version_fix branch from 38c0b46 to 227dbe4 Compare August 7, 2024 10:39
Copy link

github-actions bot commented Aug 7, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.554 ms 65.627 ms 65.713 ms]
change: [-9.7893% -6.1572% -2.9326%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

Copy link

github-actions bot commented Aug 7, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.816 ms 65.908 ms 66.034 ms]
change: [-7.7279% -4.3453% -1.5351%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

@nimrod-starkware nimrod-starkware force-pushed the nimrod/rust_version_fix branch from 227dbe4 to 9c48e48 Compare August 7, 2024 11:08
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.71%. Comparing base (09cd2b3) to head (9c48e48).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   76.73%   76.71%   -0.03%     
==========================================
  Files         318      319       +1     
  Lines       34569    34642      +73     
  Branches    34569    34642      +73     
==========================================
+ Hits        26527    26576      +49     
- Misses       5755     5777      +22     
- Partials     2287     2289       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/rust_version_fix branch from 9c48e48 to 3e68e05 Compare August 7, 2024 11:31
Copy link

github-actions bot commented Aug 7, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.360 ms 65.438 ms 65.522 ms]
change: [-4.3748% -3.3761% -2.4455%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) low severe
2 (2.00%) high mild
2 (2.00%) high severe

@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant