Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cairo_native): update compiled to 2.10.0-rc.0 #3121

Closed
wants to merge 3 commits into from

Conversation

meship-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Jan 5, 2025

@meship-starkware meship-starkware force-pushed the meship/update_compiler_version branch from 3d073ad to 46e0bc9 Compare January 5, 2025 16:21
Copy link

github-actions bot commented Jan 5, 2025

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.447 ms 34.466 ms 34.487 ms]
change: [-3.9490% -2.4027% -1.0456%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe

@meship-starkware meship-starkware changed the title chore(cairo_native): update cairo native version to 0.2.5-rc2 and the compiled to 2.10.0-rc.0 chore(cairo_native): update compiled to 2.10.0-rc.0 Jan 5, 2025
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 29 of 34 files at r1, 1 of 1 files at r2, 6 of 7 files at r3, all commit messages.
Reviewable status: 36 of 37 files reviewed, 1 unresolved discussion (waiting on @meship-starkware)


scripts/build_native_blockifier.sh line 23 at r3 (raw file):

}

# init_submodule &&

Out of curiosity- why?

Code quote:

# init_submodule &&

Copy link
Contributor Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 36 of 37 files reviewed, 1 unresolved discussion (waiting on @noaov1)


scripts/build_native_blockifier.sh line 23 at r3 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Out of curiosity- why?

just no need now that we run without native

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)

@meship-starkware meship-starkware deleted the meship/update_compiler_version branch January 6, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants