-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cairo_native): update compiled to 2.10.0-rc.0 #3121
Conversation
Artifacts upload workflows: |
3d073ad
to
46e0bc9
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 29 of 34 files at r1, 1 of 1 files at r2, 6 of 7 files at r3, all commit messages.
Reviewable status: 36 of 37 files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
scripts/build_native_blockifier.sh
line 23 at r3 (raw file):
} # init_submodule &&
Out of curiosity- why?
Code quote:
# init_submodule &&
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 36 of 37 files reviewed, 1 unresolved discussion (waiting on @noaov1)
scripts/build_native_blockifier.sh
line 23 at r3 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Out of curiosity- why?
just no need now that we run without native
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
No description provided.