feat(blockifier): take gas_consumed for CallInfo directly from CallResult #3110
Conversation
|
This change is |
|
Artifacts upload workflows: |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
TzahiTaub
force-pushed
the
01-05-feat_blockifier_take_gas_consumed_for_callinfo_directly_from_callresult
branch
from
107d854 to
5509def
Compare
TzahiTaub
force-pushed
the
01-05-feat_blockifier_take_gas_consumed_for_callinfo_directly_from_callresult
branch
from
5509def to
90a3706
Compare
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
TzahiTaub
force-pushed
the
01-05-feat_blockifier_take_gas_consumed_for_callinfo_directly_from_callresult
branch
from
90a3706 to
f8d0c84
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)
crates/blockifier/src/execution/call_info.rs line 236 at r4 (raw file):
) -> ExecutionResources { // Note: the vm resources (and entire charged resources) of a call contains the inner call // resources, unlike other fields such as events and messages,
Suggestion:
ents and messages.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @TzahiTaub)
crates/blockifier/src/execution/native/entry_point_execution.rs line 134 at r4 (raw file):
gas_consumed, }, resources: vm_resources,
It's not the type in CallInfo
Code quote:
resources: vm_resources,
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware)
crates/blockifier/src/execution/native/entry_point_execution.rs line 134 at r4 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
It's not the type in CallInfo
Yes, got confused with the next PR somehow. Reverting.
TzahiTaub
force-pushed
the
01-05-feat_blockifier_take_gas_consumed_for_callinfo_directly_from_callresult
branch
from
f8d0c84 to
78ed7ec
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status:
TzahiTaub
force-pushed
the
01-05-feat_blockifier_take_gas_consumed_for_callinfo_directly_from_callresult
branch
2 times, most recently
from
e8455bc to
5d3c324
Compare
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
TzahiTaub
force-pushed
the
01-05-feat_blockifier_take_gas_consumed_for_callinfo_directly_from_callresult
branch
from
5d3c324 to
e9026be
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status:
TzahiTaub
force-pushed
the
01-05-feat_blockifier_take_gas_consumed_for_callinfo_directly_from_callresult
branch
from
e9026be to
ae39c25
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
TzahiTaub
deleted the
01-05-feat_blockifier_take_gas_consumed_for_callinfo_directly_from_callresult
branch
No description provided.