Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cairo_native): bugfix in cairo native syscall handler #3043

Merged

Conversation

meship-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@meship-starkware meship-starkware changed the base branch from main to main-v0.13.4 December 31, 2024 16:00
@meship-starkware meship-starkware changed the title Meship/fix bugs in native syscall handler fix(cairo_native): bugfix in cairo native syscall handler Dec 31, 2024
Copy link

Artifacts upload workflows:

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)


crates/blockifier/src/execution/native/syscall_handler.rs line 381 at r1 (raw file):

            calldata: wrapper_calldata,
            storage_address: contract_address,
            caller_address: self.base.call.storage_address,

Consider defining getters as in the SyscallHintProcessor.

Code quote:

caller_address: self.base.call.storage_address,

@meship-starkware meship-starkware merged commit 06e5f87 into main-v0.13.4 Jan 1, 2025
11 of 20 checks passed
@meship-starkware meship-starkware deleted the meship/fix_bugs_in_native_syscall_handler branch January 1, 2025 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants