test(cairo_native): add native to transactions test

[meship-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-31T14:51:16Z
• Started at 2024-12-31T16:03:14Z
• Started at 2025-01-02T11:54:32Z
• Started at 2025-01-02T11:56:08Z
• Started at 2025-01-02T12:18:41Z
• Started at 2025-01-02T12:34:36Z
• Started at 2025-01-02T12:44:20Z
• Started at 2025-01-02T13:09:25Z
• Started at 2025-01-02T13:32:44Z
• Started at 2025-01-02T13:57:44Z
• Started at 2025-01-02T14:06:55Z
• Started at 2025-01-02T14:09:47Z
• Started at 2025-01-02T14:12:36Z
• Started at 2025-01-03T12:27:28Z
• Started at 2025-01-06T10:01:19Z

[noaov1]

Reviewed 4 of 6 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @avivg-starkware and @meship-starkware)

---

crates/blockifier/src/test_utils.rs line 9 at r2 (raw file):

pub mod struct_impls;
pub mod syscall;
#[cfg(test)]

Not needed as the file is already under this feature flag. See here.

Code quote:

#[cfg(test)]

---

crates/blockifier/src/test_utils/test_templates.rs line 6 at r2 (raw file):

#[template]
#[rstest]
fn cairo_version_no_native(

I think that you can all both functions cairo_version and then you can apply in one line (and use one import).

Suggestion:

fn cairo_version(

---

crates/blockifier/src/test_utils/test_templates.rs line 32 at r2 (raw file):

    cairo_version: CairoVersion,
) {
}

Remove?

Code quote:

#[cfg(not(feature = "cairo_native"))]
#[template]
#[rstest]
fn cairo_version_no_native(
    #[values(CairoVersion::Cairo0, CairoVersion::Cairo1(RunnableCairo1::Casm))]
    cairo_version: CairoVersion,
) {
}

---

crates/blockifier/src/transaction/transactions_test.rs line 485 at r2 (raw file):

        validate_gas_consumed: 4740, // The gas consumption results from parsing the input
            // arguments.
        execute_gas_consumed: 112080,

Why do we have additional vm resources in case of the casm?

Code quote:

        resources: ExecutionResources::default(),
        validate_gas_consumed: 4740, // The gas consumption results from parsing the input
            // arguments.
        execute_gas_consumed: 112080,

---

crates/blockifier/src/transaction/transactions_test.rs line 734 at r2 (raw file):

    feature = "cairo_native",
    case::with_cairo1_native_account(CairoVersion::Cairo1(RunnableCairo1::Native))
)]

Why not use the apply here?

Code quote:

#[case::with_cairo0_account(CairoVersion::Cairo0)]
#[case::with_cairo1_account(CairoVersion::Cairo1(RunnableCairo1::Casm))]
#[cfg_attr(
    feature = "cairo_native",
    case::with_cairo1_native_account(CairoVersion::Cairo1(RunnableCairo1::Native))
)]

---

crates/blockifier/src/transaction/transactions_test.rs line 909 at r2 (raw file):

    cairo_version: CairoVersion,
) {
    let account_cairo_version = cairo_version;

Why is this needed? Does the input must be called cairo_version?

Code quote:

    let account_cairo_version = cairo_version;

[meship-starkware]

Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @avivg-starkware and @noaov1)

---

crates/blockifier/src/test_utils/test_templates.rs line 6 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

I think that you can all both functions cairo_version and then you can apply in one line (and use one import).

That is a very good idea

---

crates/blockifier/src/transaction/transactions_test.rs line 734 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Why not use the apply here?

I think it more elegant to do cases when it is only three cases, but I can add the template instead

---

crates/blockifier/src/transaction/transactions_test.rs line 909 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Why is this needed? Does the input must be called cairo_version?

Yes, we might be able to resolve it with a macro but I think that is good for now

[meship-starkware]

Reviewed 1 of 7 files at r3.
Reviewable status: 2 of 8 files reviewed, 6 unresolved discussions (waiting on @avivg-starkware and @noaov1)

[meship-starkware]

Reviewed 3 of 7 files at r3, 1 of 2 files at r4.
Reviewable status: 4 of 9 files reviewed, 6 unresolved discussions (waiting on @avivg-starkware and @noaov1)

[meship-starkware]

Reviewable status: 3 of 9 files reviewed, 6 unresolved discussions (waiting on @avivg-starkware and @noaov1)

---

crates/blockifier/src/test_utils/test_templates.rs line 32 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Remove?

Done.

[meship-starkware]

Reviewable status: 3 of 9 files reviewed, 6 unresolved discussions (waiting on @avivg-starkware and @noaov1)

---

crates/blockifier/src/test_utils.rs line 9 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Not needed as the file is already under this feature flag. See here.

Done.