Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(starknet_api): fix no item named warnings (#2973) #3010

Closed
wants to merge 1 commit into from
Closed

chore(starknet_api): fix no item named warnings (#2973) #3010

wants to merge 1 commit into from

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Dec 29, 2024 •
edited
Loading

cherry-pick of #2973 into main-v0.13.4.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 29, 2024 •
edited
Loading

Artifacts upload workflows:

@ArniStarkware Graphite App
Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArniStarkware ArniStarkware mentioned this pull request Dec 29, 2024
Closed
@ArniStarkware ArniStarkware marked this pull request as ready for review December 29, 2024 16:20
@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.487 ms 34.975 ms 35.554 ms]
change: [+1.6880% +3.0116% +4.6898%] (p = 0.00 < 0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
7 (7.00%) high severe

dorimedini-starkware
dorimedini-starkware approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware
Copy link
Contributor Author

Already covered.

@ArniStarkware ArniStarkware deleted the arni/cherry-pick/warnings/docstrings_item_not_found branch December 30, 2024 08:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArniStarkware @reviewable-StarkWare @dorimedini-starkware