Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): move BlockExecutionArtifacts to the blockifier … #2989

Closed
wants to merge 1 commit into from

Conversation

DvirYo-starkware
Copy link
Contributor

…crate

@DvirYo-starkware DvirYo-starkware self-assigned this Dec 26, 2024
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Dec 26, 2024

Artifacts upload workflows:

Copy link
Contributor Author

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 8 files reviewed, 3 unresolved discussions (waiting on @alonh5, @dafnamatsry, @noaov1, and @Yael-Starkware)


crates/blockifier/src/execution_artifacts.rs line 13 at r1 (raw file):

use crate::bouncer::BouncerWeights;
use crate::state::cached_state::CommitmentStateDiff;
use crate::transaction::objects::TransactionExecutionInfo;

Copy paste from the batcher crate


crates/blockifier/src/execution_artifacts.rs line 15 at r1 (raw file):

use crate::transaction::objects::TransactionExecutionInfo;

#[cfg_attr(any(test, feature = "testing"), derive(Clone))]

Added here. in the batcher there is no testing feature

Code quote:

feature = "testing")

crates/blockifier/src/execution_artifacts.rs line 53 at r1 (raw file):

        }
    }

The return type here was changed from ProposalCommitment because this a batcher type

auto-merge was automatically disabled December 26, 2024 15:47

Pull request was closed

@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants