-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_gateway): use the get nonce method of the stateful validator trait #2982
chore(starknet_gateway): use the get nonce method of the stateful validator trait #2982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+reviewer:@Yael-Starkware
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @Yael-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
crates/starknet_gateway/src/gateway.rs
line 141 at r1 (raw file):
let address = executable_tx.contract_address(); let nonce = StatefulTransactionValidatorTrait::get_nonce(&mut validator, address).map_err(|e| {
please remove get_nonce from the trait if it isn't needed there anymore.
Code quote:
StatefulTransactionValidatorTrait::get_nonce
7e3a704
to
9226a14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)
crates/starknet_gateway/src/gateway.rs
line 141 at r1 (raw file):
Previously, Yael-Starkware (YaelD) wrote…
please remove get_nonce from the trait if it isn't needed there anymore.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
-- commits
line 2 at r2:
commit msg no longer reflects the change
Code quote:
use the get nonce method of the stateful validator trait
9226a14
to
d171f3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @Yael-Starkware)
Previously, Yael-Starkware (YaelD) wrote…
commit msg no longer reflects the change
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
No description provided.