Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_gateway): use the get nonce method of the stateful validator trait #2982

Merged

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+reviewer:@Yael-Starkware

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @Yael-Starkware)

Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)


crates/starknet_gateway/src/gateway.rs line 141 at r1 (raw file):

        let address = executable_tx.contract_address();
        let nonce =
            StatefulTransactionValidatorTrait::get_nonce(&mut validator, address).map_err(|e| {

please remove get_nonce from the trait if it isn't needed there anymore.

Code quote:

StatefulTransactionValidatorTrait::get_nonce

@ArniStarkware ArniStarkware force-pushed the arni/gateway/stateful_validator/get_nonce_using_trait branch from 7e3a704 to 9226a14 Compare December 26, 2024 14:43
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)


crates/starknet_gateway/src/gateway.rs line 141 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

please remove get_nonce from the trait if it isn't needed there anymore.

Done.

Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)


-- commits line 2 at r2:
commit msg no longer reflects the change

Code quote:

use the get nonce method of the stateful validator trait

@ArniStarkware ArniStarkware force-pushed the arni/gateway/stateful_validator/get_nonce_using_trait branch from 9226a14 to d171f3b Compare December 26, 2024 15:14
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @Yael-Starkware)


-- commits line 2 at r2:

Previously, Yael-Starkware (YaelD) wrote…

commit msg no longer reflects the change

Done.

Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware marked this pull request as ready for review December 29, 2024 06:46
@ArniStarkware ArniStarkware added this pull request to the merge queue Dec 29, 2024
Merged via the queue into main with commit 217d859 Dec 29, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants