Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): erase block_hash_contract_address #2660

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yonatan-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Dec 15, 2024

@Yonatan-Starkware Yonatan-Starkware marked this pull request as ready for review December 15, 2024 08:03
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.15%. Comparing base (e3165c4) to head (045d2c5).
Report is 833 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2660       +/-   ##
===========================================
+ Coverage   40.10%   68.15%   +28.04%     
===========================================
  Files          26      105       +79     
  Lines        1895    14311    +12416     
  Branches     1895    14311    +12416     
===========================================
+ Hits          760     9753     +8993     
- Misses       1100     4129     +3029     
- Partials       35      429      +394     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blockifier/erase_block_hash_contract_address branch from 045d2c5 to b981564 Compare December 15, 2024 15:02
@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blockifier/erase_block_hash_contract_address branch from b981564 to 7ef8da0 Compare December 15, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants