Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_sequencer_node): remove option from client struct #2659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Dec 14, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 6.29%. Comparing base (e3165c4) to head (c3d7b44).
Report is 822 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_sequencer_node/src/clients.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2659       +/-   ##
==========================================
- Coverage   40.10%   6.29%   -33.81%     
==========================================
  Files          26     282      +256     
  Lines        1895   32424    +30529     
  Branches     1895   32424    +30529     
==========================================
+ Hits          760    2042     +1282     
- Misses       1100   30294    +29194     
- Partials       35      88       +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants