Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_sierra_compile): path cleanups #2654

Open
wants to merge 1 commit into
base: spr/main/04960d2f
Choose a base branch
from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Dec 12, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.51%. Comparing base (7ab0cf6) to head (59c2879).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           spr/main/04960d2f   #2654       +/-   ##
=====================================================
- Coverage              78.82%   0.51%   -78.31%     
=====================================================
  Files                      4      98       +94     
  Lines                     85   13370    +13285     
  Branches                  85   13370    +13285     
=====================================================
+ Hits                      67      69        +2     
- Misses                    12   13294    +13282     
- Partials                   6       7        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants