fix(ci): fix the linker fix #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
giladchase
force-pushed
the
gilad/better-linker-fix
branch
5 times, most recently
from
3c1eee5 to
2a9c82a
Compare
|
Artifacts upload workflows: |
|
Benchmark movements: |
giladchase
force-pushed
the
gilad/better-linker-fix
branch
2 times, most recently
from
01f6c8a to
7d76d51
Compare
- Looks like adding to RUSTFLAGS env in the CI is not an append, it's an override, which runs over the RUSTFLAGS linker fix in config.toml. - The change in config.toml is unrelated, just makes it more robust for local use.
giladchase
force-pushed
the
gilad/better-linker-fix
branch
from
7d76d51 to
6addc4f
Compare
dorimedini-starkware
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @adi-yakovian-starkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous fix added stable- target, didn't work.
This one is truly agnostic to rust version and should work on all linux targets.