Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gilad/try cfg #2634

Closed
wants to merge 3 commits into from
Closed

Gilad/try cfg #2634

wants to merge 3 commits into from

Conversation

giladchase
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload workflows:

Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [30.970 ms 31.441 ms 32.006 ms]
change: [+1.0733% +2.7335% +4.4423%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
9 (9.00%) high severe

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 77.20%. Comparing base (e3165c4) to head (b14da88).
Report is 809 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_l1_provider_types/src/lib.rs 0.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2634       +/-   ##
===========================================
+ Coverage   40.10%   77.20%   +37.10%     
===========================================
  Files          26      393      +367     
  Lines        1895    42504    +40609     
  Branches     1895    42504    +40609     
===========================================
+ Hits          760    32816    +32056     
- Misses       1100     7394     +6294     
- Partials       35     2294     +2259     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giladchase giladchase closed this Dec 10, 2024
@giladchase giladchase deleted the gilad/try-cfg branch December 10, 2024 14:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants