Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native_blockifier): activate testing feature only in dev dependencies #2624

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Dec 10, 2024

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.44%. Comparing base (e3165c4) to head (06da31a).
Report is 813 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2624       +/-   ##
===========================================
+ Coverage   40.10%   60.44%   +20.33%     
===========================================
  Files          26      153      +127     
  Lines        1895    19579    +17684     
  Branches     1895    19579    +17684     
===========================================
+ Hits          760    11834    +11074     
- Misses       1100     6992     +5892     
- Partials       35      753      +718     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 12-10-fix_native_blockifier_activate_testing_feature_only_in_dev_dependencies branch 4 times, most recently from 06da31a to 4acec9b Compare December 15, 2024 08:56
@dorimedini-starkware dorimedini-starkware force-pushed the 12-10-fix_native_blockifier_activate_testing_feature_only_in_dev_dependencies branch from 4acec9b to 96c2043 Compare December 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants