chore(papyrus_p2p_sync): add block data receiver to p2psyncclient #2617
Conversation
|
This change is |
eitanm-starkware
force-pushed
the
eitan/add_block_data_receiver_to_p2psyncclient_constructor
branch
from
dc1c438 to
a27919f
Compare
eitanm-starkware
force-pushed
the
eitan/add_block_data_receiver_to_p2psyncclient_constructor
branch
2 times, most recently
from
ee0e600 to
583173e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2617 +/- ##
===========================================
+ Coverage 40.10% 77.39% +37.28%
===========================================
Files 26 395 +369
Lines 1895 42649 +40754
Branches 1895 42649 +40754
===========================================
+ Hits 760 33008 +32248
- Misses 1100 7345 +6245
- Partials 35 2296 +2261 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @eitanm-starkware)
crates/papyrus_node/src/run.rs line 307 at r1 (raw file):
storage_writer, p2p_sync_client_channels, Box::pin(futures::stream::pending()),
use .boxed() instead
crates/papyrus_p2p_sync/src/client/mod.rs line 233 at r1 (raw file):
p2p_sync_channels: P2PSyncClientChannels, #[allow(dead_code)] block_data_receiver: BoxStream<'static, SyncBlock>,
rename to internal_blocks_receiver
eitanm-starkware
force-pushed
the
eitan/add_block_data_receiver_to_p2psyncclient_constructor
branch
from
583173e to
138ae92
Compare
There was a problem hiding this comment.
Reviewable status: 2 of 6 files reviewed, 2 unresolved discussions (waiting on @ShahakShama)
crates/papyrus_node/src/run.rs line 307 at r1 (raw file):
Previously, ShahakShama wrote…
use .boxed() instead
Done.
crates/papyrus_p2p_sync/src/client/mod.rs line 233 at r1 (raw file):
Previously, ShahakShama wrote…
rename to internal_blocks_receiver
Done.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)
eitanm-starkware
force-pushed
the
eitan/add_block_data_receiver_to_p2psyncclient_constructor
branch
from
138ae92 to
f4eab0f
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware)
crates/papyrus_p2p_sync/src/client/mod.rs line 233 at r3 (raw file):
p2p_sync_channels: P2PSyncClientChannels, #[allow(dead_code)] internal_blocks_receiver: BoxStream<'static, SyncBlock>,
Should be (BlockNumber, SyncBlock)
eitanm-starkware
force-pushed
the
eitan/add_block_data_receiver_to_p2psyncclient_constructor
branch
from
f4eab0f to
fd7a70e
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware)
crates/papyrus_p2p_sync/src/client/mod.rs line 233 at r3 (raw file):
Previously, ShahakShama wrote…
Should be (BlockNumber, SyncBlock)
Could you put BlockNumber first? That's the convention in other places in the code (Including your previous PR)
eitanm-starkware
force-pushed
the
eitan/add_block_data_receiver_to_p2psyncclient_constructor
branch
2 times, most recently
from
7f54bd2 to
eb62875
Compare
|
Benchmark movements: |
eitanm-starkware
force-pushed
the
eitan/add_block_data_receiver_to_p2psyncclient_constructor
branch
from
eb62875 to
14e0b30
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status:
eitanm-starkware
force-pushed
the
eitan/add_block_data_receiver_to_p2psyncclient_constructor
branch
from
14e0b30 to
573a7a2
Compare
No description provided.