Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(starknet_state_sync): move storage reader from StateSyncRunner to StateSync #2592

Merged
merged 1 commit into from
Dec 10, 2024
Merged

refactor(starknet_state_sync): move storage reader from StateSyncRunner to StateSync #2592

merged 1 commit into from
Dec 10, 2024

Conversation

ShahakShama
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Dec 9, 2024 •
edited by alon-dotan-starkware
Loading

This change is Reviewable

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

Artifacts upload workflows:

@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 27.73%. Comparing base (e3165c4) to head (1a2cfe8).
Report is 789 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_state_sync/src/lib.rs 0.00% 16 Missing ⚠️
crates/starknet_state_sync/src/runner/mod.rs 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2592       +/-   ##
===========================================
- Coverage   40.10%   27.73%   -12.37%     
===========================================
  Files          26        4       -22     
  Lines        1895      274     -1621     
  Branches     1895      274     -1621     
===========================================
- Hits          760       76      -684     
+ Misses       1100      191      -909     
+ Partials       35        7       -28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShahakShama ShahakShama force-pushed the shahak/move_storage_reader_to_state_sync branch from 6bce9ce to e9f8edf Compare December 10, 2024 07:55
@ShahakShama ShahakShama force-pushed the shahak/move_storage_reader_to_state_sync branch from e9f8edf to 1a2cfe8 Compare December 10, 2024 08:45
AlonLStarkWare
AlonLStarkWare reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@AlonLStarkWare AlonLStarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @eitanm-starkware and @noamsp-starkware)

AlonLStarkWare
AlonLStarkWare approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@AlonLStarkWare AlonLStarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware and @noamsp-starkware)

AlonLStarkWare
AlonLStarkWare approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@AlonLStarkWare AlonLStarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware and @noamsp-starkware)

@ShahakShama ShahakShama merged commit a24b326 into main Dec 10, 2024
11 checks passed
@ShahakShama ShahakShama deleted the shahak/move_storage_reader_to_state_sync branch December 10, 2024 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlonLStarkWare AlonLStarkWare AlonLStarkWare approved these changes

@noamsp-starkware noamsp-starkware Awaiting requested review from noamsp-starkware

@eitanm-starkware eitanm-starkware Awaiting requested review from eitanm-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShahakShama @reviewable-StarkWare @AlonLStarkWare