-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_sequencer_node): set monitoring as active component #2576
Conversation
0bc3de8
to
8bc8636
Compare
8bc8636
to
e0dd54d
Compare
Artifacts upload workflows: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2576 +/- ##
==========================================
- Coverage 40.10% 38.08% -2.02%
==========================================
Files 26 278 +252
Lines 1895 32141 +30246
Branches 1895 32141 +30246
==========================================
+ Hits 760 12242 +11482
- Misses 1100 18868 +17768
- Partials 35 1031 +996 ☔ View full report in Codecov by Sentry. |
ae9ecc2
to
2ade4e3
Compare
2ade4e3
to
2fc02ad
Compare
commit-id:c30a0cee
2fc02ad
to
8342984
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: 5 of 6 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/starknet_sequencer_node/src/config/component_config.rs
line 33 at r3 (raw file):
// Reactive component configs. pub monitoring_endpoint: ActiveComponentExecutionConfig,
What do you think about using two fields here: active_components
, which would be a struct containing all active components, and reactive_components
, another struct? This would be similar to the servers
struct, which has three fields: local
, remote
, and wrapper
.
Code quote:
// Reactive component configs.
#[validate]
pub batcher: ReactiveComponentExecutionConfig,
#[validate]
pub consensus_manager: ReactiveComponentExecutionConfig,
#[validate]
pub gateway: ReactiveComponentExecutionConfig,
#[validate]
pub http_server: ReactiveComponentExecutionConfig,
#[validate]
pub mempool: ReactiveComponentExecutionConfig,
#[validate]
pub mempool_p2p: ReactiveComponentExecutionConfig,
#[validate]
pub state_sync: ReactiveComponentExecutionConfig,
// Reactive component configs.
pub monitoring_endpoint: ActiveComponentExecutionConfig,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
✓ Commit merged in pull request #2600 |
Stack: