Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_sequencer_node): set monitoring as active component #2576

Closed
wants to merge 1 commit into from

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the spr/main/c30a0cee branch 2 times, most recently from 0bc3de8 to 8bc8636 Compare December 9, 2024 13:04
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/794b2125 to main December 9, 2024 13:06
Copy link

github-actions bot commented Dec 9, 2024

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 38.08%. Comparing base (e3165c4) to head (8342984).
Report is 796 commits behind head on main.

Files with missing lines Patch % Lines
...tes/starknet_integration_tests/src/config_utils.rs 0.00% 2 Missing ⚠️
crates/starknet_sequencer_node/src/components.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2576      +/-   ##
==========================================
- Coverage   40.10%   38.08%   -2.02%     
==========================================
  Files          26      278     +252     
  Lines        1895    32141   +30246     
  Branches     1895    32141   +30246     
==========================================
+ Hits          760    12242   +11482     
- Misses       1100    18868   +17768     
- Partials       35     1031     +996     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: 5 of 6 files reviewed, all discussions resolved

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/starknet_sequencer_node/src/config/component_config.rs line 33 at r3 (raw file):

    // Reactive component configs.
    pub monitoring_endpoint: ActiveComponentExecutionConfig,

What do you think about using two fields here: active_components, which would be a struct containing all active components, and reactive_components, another struct? This would be similar to the servers struct, which has three fields: local, remote, and wrapper.

Code quote:

    // Reactive component configs.
    #[validate]
    pub batcher: ReactiveComponentExecutionConfig,
    #[validate]
    pub consensus_manager: ReactiveComponentExecutionConfig,
    #[validate]
    pub gateway: ReactiveComponentExecutionConfig,
    #[validate]
    pub http_server: ReactiveComponentExecutionConfig,
    #[validate]
    pub mempool: ReactiveComponentExecutionConfig,
    #[validate]
    pub mempool_p2p: ReactiveComponentExecutionConfig,
    #[validate]
    pub state_sync: ReactiveComponentExecutionConfig,

    // Reactive component configs.
    pub monitoring_endpoint: ActiveComponentExecutionConfig,

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #2600

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants