chore: change sequencer_node_handle type to Vec to support multiple handles #2572
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2024
|
This change is |
nadin-Starkware
changed the base branch from
spr/main/7154c3ab
to
spr/main/2fc6a8c4
nadin-Starkware
force-pushed
the
spr/main/1900daf0
branch
from
bd3ced2 to
56a2186
Compare
|
Artifacts upload workflows: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## spr/main/2fc6a8c4 #2572 +/- ##
====================================================
Coverage ? 34.09%
====================================================
Files ? 276
Lines ? 32105
Branches ? 32105
====================================================
Hits ? 10946
Misses ? 20165
Partials ? 994 ☔ View full report in Codecov by Sentry. |
nadin-Starkware
force-pushed
the
spr/main/1900daf0
branch
from
56a2186 to
2a7252c
Compare
nadin-Starkware
force-pushed
the
spr/main/2fc6a8c4
branch
from
bed8fdd to
c4fd146
Compare
This was referenced Dec 9, 2024
nadin-Starkware
force-pushed
the
spr/main/1900daf0
branch
from
2a7252c to
9726ac0
Compare
Itay-Tsabary-Starkware
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
nadin-Starkware
force-pushed
the
spr/main/2fc6a8c4
branch
from
216b1c1 to
7015d30
Compare
nadin-Starkware
force-pushed
the
spr/main/1900daf0
branch
from
9726ac0 to
70d8ba6
Compare
…andles commit-id:1900daf0
nadin-Starkware
force-pushed
the
spr/main/1900daf0
branch
from
70d8ba6 to
3ef7ccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack: