Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): set syscall tests to get runnable version #2543

Merged

Conversation

meship-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Dec 9, 2024

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.59%. Comparing base (e3165c4) to head (5ef1866).
Report is 757 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2543       +/-   ##
===========================================
+ Coverage   40.10%   71.59%   +31.49%     
===========================================
  Files          26       98       +72     
  Lines        1895    13611    +11716     
  Branches     1895    13611    +11716     
===========================================
+ Hits          760     9745     +8985     
- Misses       1100     3436     +2336     
- Partials       35      430      +395     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @meship-starkware)


crates/blockifier/src/execution/syscalls/syscall_tests/deploy.rs line 71 at r1 (raw file):

fn no_constructor_nonempty_calldata(runnable_version: RunnableCairo1) {
    let deployer_contract = FeatureContract::TestContract(CairoVersion::Cairo1(runnable_version));
    let empty_contract = FeatureContract::Empty(CairoVersion::Cairo1(RunnableCairo1::Casm));

Suggestion:

y(CairoVersion::Cairo1(runnable_version)

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 35 at r1 (raw file):

fn test_call_contract_that_panics(runnable_version: RunnableCairo1) {
    let test_contract = FeatureContract::TestContract(CairoVersion::Cairo1(runnable_version));
    let empty_contract = FeatureContract::Empty(CairoVersion::Cairo1(RunnableCairo1::Casm));

Try it

Suggestion:

(CairoVersion::Cairo1(runnable_version)

@meship-starkware meship-starkware force-pushed the meship/change_syscall_tests_to_get_runnable_cairo1 branch from 04fab06 to a95f5cd Compare December 9, 2024 09:53
@meship-starkware meship-starkware force-pushed the meship/change_syscall_tests_to_get_runnable_cairo1 branch from a95f5cd to 5ef1866 Compare December 9, 2024 10:07
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@meship-starkware meship-starkware merged commit 4269d45 into main Dec 9, 2024
13 checks passed
@meship-starkware meship-starkware deleted the meship/change_syscall_tests_to_get_runnable_cairo1 branch December 9, 2024 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants