Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(consensus): use non zero values as validator id #2436

Closed
wants to merge 1 commit into from

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Dec 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.20%. Comparing base (e3165c4) to head (249fc0b).
Report is 726 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2436       +/-   ##
===========================================
- Coverage   40.10%   14.20%   -25.91%     
===========================================
  Files          26      224      +198     
  Lines        1895    30491    +28596     
  Branches     1895    30491    +28596     
===========================================
+ Hits          760     4330     +3570     
- Misses       1100    25793    +24693     
- Partials       35      368      +333     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware
Copy link
Contributor Author

No longer relevant.

@ArniStarkware ArniStarkware deleted the arni/consensus/validator_id/non_zero branch December 5, 2024 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants