Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blockifier): add global max_sierra_gas to versioned constants #2330

Merged
merged 1 commit into from
Dec 3, 2024
Merged

chore(blockifier): add global max_sierra_gas to versioned constants #2330

merged 1 commit into from
Dec 3, 2024

Conversation

aner-starkware
Copy link
Contributor

No description provided.

@aner-starkware aner-starkware self-assigned this Nov 28, 2024
@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Artifacts upload workflows:

@aner-starkware aner-starkware force-pushed the aner/global_max_sierra_gas branch from cc3b301 to ad9040d Compare November 28, 2024 11:57
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (e3165c4) to head (ab923d0).
Report is 661 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2330       +/-   ##
===========================================
+ Coverage   40.10%   68.85%   +28.74%     
===========================================
  Files          26      108       +82     
  Lines        1895    14028    +12133     
  Branches     1895    14028    +12133     
===========================================
+ Hits          760     9659     +8899     
- Misses       1100     3956     +2856     
- Partials       35      413      +378

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aner-starkware aner-starkware force-pushed the aner/global_max_sierra_gas branch from ad9040d to ff70b1c Compare November 28, 2024 12:33
aner-starkware
aner-starkware commented Nov 28, 2024
View reviewed changes
Copy link
Contributor Author

@aner-starkware aner-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python side: https://reviewable.io/reviews/starkware-industries/starkware/36341

Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @aner-starkware)

@aner-starkware aner-starkware force-pushed the aner/global_max_sierra_gas branch from ff70b1c to d33ffac Compare November 28, 2024 13:55
@aner-starkware aner-starkware marked this pull request as ready for review November 28, 2024 14:36
dorimedini-starkware
dorimedini-starkware requested changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 8 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware, @TzahiTaub, and @Yoni-Starkware)

crates/blockifier/src/versioned_constants.rs line 184 at r2 (raw file):

    pub max_recursion_depth: usize,
    pub validate_max_n_steps: u32,
    pub validate_max_sierra_gas: u64,

can you deserialize / serialize directly to GasAmount?

Suggestion:

    pub execute_max_sierra_gas: GasAmount,
    pub deprecated_l2_resource_gas_costs: ArchivalDataGasCosts,
    pub archival_data_gas_costs: ArchivalDataGasCosts,
    pub max_recursion_depth: usize,
    pub validate_max_n_steps: u32,
    pub validate_max_sierra_gas: GasAmount,

@aner-starkware aner-starkware force-pushed the aner/global_max_sierra_gas branch 2 times, most recently from b643703 to 8eadf8e Compare December 1, 2024 12:19
dorimedini-starkware
dorimedini-starkware approved these changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub and @Yoni-Starkware)

@aner-starkware aner-starkware force-pushed the aner/global_max_sierra_gas branch 3 times, most recently from a4ecb0c to 064540d Compare December 2, 2024 09:55
@aner-starkware aner-starkware force-pushed the aner/global_max_sierra_gas branch from 064540d to ab923d0 Compare December 2, 2024 12:04
@aner-starkware aner-starkware merged commit 1aa2fae into main Dec 3, 2024
13 checks passed
@aner-starkware aner-starkware deleted the aner/global_max_sierra_gas branch December 3, 2024 07:21
@aner-starkware aner-starkware restored the aner/global_max_sierra_gas branch December 3, 2024 07:31
@aner-starkware aner-starkware deleted the aner/global_max_sierra_gas branch December 3, 2024 07:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

@Yoni-Starkware Yoni-Starkware Awaiting requested review from Yoni-Starkware

@TzahiTaub TzahiTaub Awaiting requested review from TzahiTaub

Assignees

@aner-starkware aner-starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aner-starkware @reviewable-StarkWare @dorimedini-starkware