chore(infra): add run_until utility fn

[Itay-Tsabary-Starkware]

Stack:

• chore(infra): add run_until utility fn #2320 ⬅
• chore(tests_integration): read nonce of latest block #2322
• chore(tests_integration): move node runner test util #2319
• chore(tests_integration): move http client test util #2314

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-11-28T08:47:13Z
• Started at 2024-11-28T09:00:06Z
• Started at 2024-11-28T08:59:59Z
• Started at 2024-11-28T09:00:06Z

[github-actions]

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.703 ms 29.744 ms 29.789 ms]
change: [-4.1874% -4.0066% -3.8218%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.712 ms 34.770 ms 34.837 ms]
change: [-4.6361% -3.1375% -1.8010%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
4 (4.00%) high mild
2 (2.00%) high severe

full_committer_flow performance improved 😺
full_committer_flow time: [30.326 ms 30.393 ms 30.463 ms]
change: [-3.6859% -3.3924% -3.0925%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

[codecov]

Codecov Report

Attention: Patch coverage is 57.69231% with 33 lines in your changes missing coverage. Please review.

Please upload report for BASE (spr/main/4d0abfb5@8edd6d7). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
crates/infra_utils/src/run_until.rs	44.89%	21 Missing and 6 partials ⚠️
...rknet_sequencer_node/src/test_utils/compilation.rs	79.31%	2 Missing and 4 partials ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##             spr/main/4d0abfb5    #2320   +/-   ##
====================================================
  Coverage                     ?   77.40%           
====================================================
  Files                        ?      387           
  Lines                        ?    40685           
  Branches                     ?    40685           
====================================================
  Hits                         ?    31493           
  Misses                       ?     6862           
  Partials                     ?     2330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lev-starkware]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/infra_utils/src/run_until_test.rs line 20 at r1 (raw file):

    // Run the function with a short interval and a maximum of 5 attempts.
    let result = run_until(100, 5, mock_executable, condition, None).await;

Don't you want to test that tracing works?

---

crates/infra_utils/src/run_until.rs line 11 at r1 (raw file):

pub struct TraceConfig {
    pub level: LogLevel,
    pub message: String,

I think its more message_prefix than message.

Code quote:

message

---

crates/infra_utils/src/run_until.rs line 79 at r1 (raw file):

    if let Some(config) = &trace_config {
        let failure_message =
            format!("{}: Condition not met after {} attempts.", config.message, max_attempts);

I suggest something like: Condition not met after the maximum number of attempts - {}

Code quote:

Condition not met after {} attempts

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!