chore(ci): update commitlint #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Itay-Tsabary-Starkware
force-pushed
the
spr/main/b131efeb
branch
from
07f8f21 to
e966229
Compare
dorimedini-starkware
requested changes
Nov 28, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
commitlint.config.js line 46 at r1 (raw file):
'mempool_p2p', 'mempool_p2p_types', 'mempool_test_utils',
where did this go?
Code quote:
'mempool_test_utils',
commit-id:b131efeb
Itay-Tsabary-Starkware
force-pushed
the
spr/main/b131efeb
branch
from
e966229 to
4f57571
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
commitlint.config.js line 46 at r1 (raw file):
Previously, dorimedini-starkware wrote…
where did this go?
Done.
dorimedini-starkware
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.