Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier_reexecution): move offline reader to separate file #2312

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

aner-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 156 lines in your changes missing coverage. Please review.

Project coverage is 41.48%. Comparing base (e3165c4) to head (4bd767f).
Report is 622 commits behind head on main.

Files with missing lines Patch % Lines
...execution/src/state_reader/offline_state_reader.rs 0.00% 155 Missing ⚠️
...s/blockifier_reexecution/src/state_reader/utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2312      +/-   ##
==========================================
+ Coverage   40.10%   41.48%   +1.37%     
==========================================
  Files          26      206     +180     
  Lines        1895    24172   +22277     
  Branches     1895    24172   +22277     
==========================================
+ Hits          760    10027    +9267     
- Misses       1100    13677   +12577     
- Partials       35      468     +433     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aner-starkware aner-starkware force-pushed the aner/move_offline_state_reader branch from 2e696c7 to 4bd767f Compare November 27, 2024 16:44
@aner-starkware aner-starkware changed the title refactor(blockifier_reexecution): move offline state reader to separate file refactor(blockifier_reexecution): move offline reader to separate file Nov 27, 2024
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@aner-starkware aner-starkware merged commit be65c40 into main Nov 28, 2024
11 of 18 checks passed
@aner-starkware aner-starkware deleted the aner/move_offline_state_reader branch November 28, 2024 11:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants