Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync): create state sync client #2308

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

noamsp-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

noamsp-starkware commented Nov 27, 2024

Base automatically changed from noam.s/create_state_sync_channels to main November 27, 2024 14:50
Copy link

Artifacts upload workflows:

@noamsp-starkware noamsp-starkware force-pushed the noam.s/create_state_sync_client branch from 537f2b4 to 2ab124b Compare November 28, 2024 10:50
@noamsp-starkware noamsp-starkware marked this pull request as ready for review November 28, 2024 11:03
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 6.13%. Comparing base (e3165c4) to head (2ab124b).
Report is 633 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_sequencer_node/src/clients.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2308       +/-   ##
==========================================
- Coverage   40.10%   6.13%   -33.97%     
==========================================
  Files          26     271      +245     
  Lines        1895   31194    +29299     
  Branches     1895   31194    +29299     
==========================================
+ Hits          760    1914     +1154     
- Misses       1100   29204    +28104     
- Partials       35      76       +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)

@noamsp-starkware noamsp-starkware merged commit 6f268c8 into main Nov 28, 2024
10 checks passed
@noamsp-starkware noamsp-starkware deleted the noam.s/create_state_sync_client branch November 28, 2024 15:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants