chore(starknet_batcher): extract propose/validate block inputs into function

[alonh5]

No description provided.

[reviewable-StarkWare]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.34%. Comparing base (e3165c4) to head (7cbd5e2).
Report is 788 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #2306       +/-   ##
==========================================
- Coverage   40.10%   6.34%   -33.77%     
==========================================
  Files          26     141      +115     
  Lines        1895   17183    +15288     
  Branches     1895   17183    +15288     
==========================================
+ Hits          760    1090      +330     
- Misses       1100   16020    +14920     
- Partials       35      73       +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yael-Starkware]

beautiful!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[alonh5]

Thanks!

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[Yael-Starkware]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @ArniStarkware)

---

crates/starknet_batcher/src/batcher_test.rs line 85 at r3 (raw file):

        deadline: deadline(),
        retrospective_block_hash: None,
        block_info: Default::default(),

why not use the initial_block_info() for all tests?

Code quote:

Default::default()

---

crates/starknet_batcher/src/batcher_test.rs line 94 at r3 (raw file):

        deadline: deadline(),
        retrospective_block_hash: None,
        block_info: Default::default(),

same

Code quote:

block_info: Default::default(),

[alonh5]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @ArniStarkware and @Yael-Starkware)

---

crates/starknet_batcher/src/batcher_test.rs line 85 at r3 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

why not use the initial_block_info() for all tests?

Done.

---

crates/starknet_batcher/src/batcher_test.rs line 94 at r3 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

same

Done.

[alonh5]

• chore(starknet_batcher): extract propose/validate block inputs into function #2306 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Yael-Starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[alonh5]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)