test(starknet_mempool): tx added to mempool are forwarded to propagator client

[AlonLStarkWare]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-11-26T13:35:44Z
• Started at 2024-11-26T13:39:22Z
• Started at 2024-11-26T13:44:54Z
• Started at 2024-12-02T12:28:26Z
• Started at 2024-12-02T12:33:42Z
• Started at 2024-12-02T14:08:41Z
• Started at 2024-12-02T14:21:13Z
• Started at 2024-12-02T14:51:17Z
• Started at 2024-12-02T16:34:20Z

[ShahakShama]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @AlonLStarkWare and @eitanm-starkware)

---

crates/starknet_mempool_p2p_types/src/communication.rs line 23 at r1 (raw file):

use crate::mempool_p2p_types::MempoolP2pPropagatorResult;

#[automock]

Activate this only in feature testing and cfg test

---

crates/starknet_mempool/src/mempool_test.rs line 708 at r1 (raw file):

async fn test_new_tx_sent_to_p2p(mempool: Mempool) {
    // add_tx_input! creates an Invoke Transaction
    let tx_1_args = add_tx_input!(tx_hash: 1, address: "0x0", tx_nonce: 2, account_nonce: 2);

rename to tx_args

---

crates/starknet_mempool/src/mempool_test.rs line 709 at r1 (raw file):

    // add_tx_input! creates an Invoke Transaction
    let tx_1_args = add_tx_input!(tx_hash: 1, address: "0x0", tx_nonce: 2, account_nonce: 2);
    let new_tx_args =

rename to propagator_args

---

crates/starknet_mempool/src/mempool_test.rs line 711 at r1 (raw file):

    let new_tx_args =
        AddTransactionArgsWrapper { args: tx_1_args.clone(), p2p_message_metadata: None };
    let new_rpc_tx = match tx_1_args.tx {

rename to rpc_tx

---

crates/starknet_mempool/src/mempool_test.rs line 711 at r1 (raw file):

    let new_tx_args =
        AddTransactionArgsWrapper { args: tx_1_args.clone(), p2p_message_metadata: None };
    let new_rpc_tx = match tx_1_args.tx {

add TODO to use regular conversion once we have a compiler component

---

crates/starknet_mempool/src/mempool_test.rs line 741 at r1 (raw file):

async fn test_propagated_tx_sent_to_p2p(mempool: Mempool) {
    // add_tx_input! creates an Invoke Transaction
    let tx_2_args = add_tx_input!(tx_hash: 2, address: "0x0", tx_nonce: 3, account_nonce: 2);

rename to propagator_args

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.66%. Comparing base (e3165c4) to head (5388360).
Report is 700 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2288       +/-   ##
===========================================
+ Coverage   40.10%   77.66%   +37.56%     
===========================================
  Files          26      387      +361     
  Lines        1895    41058    +39163     
  Branches     1895    41058    +39163     
===========================================
+ Hits          760    31889    +31129     
- Misses       1100     6916     +5816     
- Partials       35     2253     +2218     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AlonLStarkWare]

Reviewable status: 0 of 6 files reviewed, 6 unresolved discussions (waiting on @eitanm-starkware and @ShahakShama)

---

crates/starknet_mempool/src/mempool_test.rs line 708 at r1 (raw file):

Previously, ShahakShama wrote…

rename to tx_args

Done.

---

crates/starknet_mempool/src/mempool_test.rs line 709 at r1 (raw file):

Previously, ShahakShama wrote…

rename to propagator_args

Done.

---

crates/starknet_mempool/src/mempool_test.rs line 711 at r1 (raw file):

Previously, ShahakShama wrote…

rename to rpc_tx

Done.

---

crates/starknet_mempool/src/mempool_test.rs line 711 at r1 (raw file):

Previously, ShahakShama wrote…

add TODO to use regular conversion once we have a compiler component

Done
But what does a compiler component have to do with this conversion?

---

crates/starknet_mempool/src/mempool_test.rs line 741 at r1 (raw file):

Previously, ShahakShama wrote…

rename to propagator_args

Done.

---

crates/starknet_mempool_p2p_types/src/communication.rs line 23 at r1 (raw file):

Previously, ShahakShama wrote…

Activate this only in feature testing and cfg test

Done.

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.985 ms 35.245 ms 35.547 ms]
change: [+1.0465% +1.7809% +2.5551%] (p = 0.00 < 0.05)
Performance has regressed.
Found 15 outliers among 100 measurements (15.00%)
2 (2.00%) high mild
13 (13.00%) high severe

[ShahakShama]

Reviewed 6 of 6 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)