Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_api): rename contract class to sierra contract class #2276

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review November 25, 2024 15:23
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.31%. Comparing base (e3165c4) to head (8b84db9).
Report is 580 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_protobuf/src/converters/class.rs 0.00% 3 Missing ⚠️
crates/native_blockifier/src/storage.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2276       +/-   ##
===========================================
+ Coverage   40.10%   68.31%   +28.20%     
===========================================
  Files          26      236      +210     
  Lines        1895    30820    +28925     
  Branches     1895    30820    +28925     
===========================================
+ Hits          760    21054    +20294     
- Misses       1100     7958     +6858     
- Partials       35     1808     +1773     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_sn_api_contract_class_name branch from af4e82f to 975b893 Compare November 26, 2024 07:01
@AvivYossef-starkware AvivYossef-starkware changed the title refactor(starknet_api): change contract class name to sierra contract class refactor(starknet_api): rename contract class name to sierra contract class Nov 26, 2024
@AvivYossef-starkware AvivYossef-starkware changed the title refactor(starknet_api): rename contract class name to sierra contract class refactor(starknet_api): rename contract class to sierra contract class Nov 26, 2024
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_sn_api_contract_class_name branch 2 times, most recently from 90127f0 to d7f67f0 Compare November 26, 2024 07:40
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_sn_api_contract_class_name branch from d7f67f0 to 8b84db9 Compare November 26, 2024 07:40
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 26 of 26 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@AvivYossef-starkware AvivYossef-starkware merged commit fcf5cce into main Nov 26, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants