feat(blockifier): support reverts in native

[Yoni-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2024-11-25T13:28:13Z
• Started at 2024-11-25T13:45:59Z

[ilyalesokhin-starkware]

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 68 at r1 (raw file):

    for call in res.iter() {
        assert_eq!(call.tracked_resource, TrackedResource::SierraGas);
    }

Using SierraGas without cairo-native is not supported?

Code quote:

    // Check that the tracked resource is SierraGas to make sure that Native is running.
    for call in res.iter() {
        assert_eq!(call.tracked_resource, TrackedResource::SierraGas);
    }

[ilyalesokhin-starkware]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @dorimedini-starkware, and @Yoni-Starkware)

[Yoni-Starkware]

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @dorimedini-starkware, and @ilyalesokhin-starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 68 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Using SierraGas without cairo-native is not supported?

It is supported. But is the resource was CairoSteps, the Native class would be replace with casm.
This check is to verify that the native case is not replaced under the hood.

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.70%. Comparing base (e3165c4) to head (9692b16).
Report is 576 commits behind head on main.

Files with missing lines	Patch %	Lines
.../blockifier/src/execution/syscalls/syscall_base.rs	89.47%	0 Missing and 2 partials ⚠️
crates/blockifier/src/execution/syscalls/mod.rs	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2271       +/-   ##
===========================================
+ Coverage   40.10%   68.70%   +28.60%     
===========================================
  Files          26      108       +82     
  Lines        1895    13891    +11996     
  Branches     1895    13891    +11996     
===========================================
+ Hits          760     9544     +8784     
- Misses       1100     3937     +2837     
- Partials       35      410      +375     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[ilyalesokhin-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @dorimedini-starkware, and @Yoni-Starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 68 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

It is supported. But is the resource was CairoSteps, the Native class would be replace with casm.
This check is to verify that the native case is not replaced under the hood.

it feels like a bad check for usage of native.

[Yoni-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware, @dorimedini-starkware, and @ilyalesokhin-starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 68 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

it feels like a bad check for usage of native.

Native yes/no should be transparent :(
I'll think about a better indication