chore(infra): canonicalize path resolution

[Itay-Tsabary-Starkware]

Stack:

• chore(tests_integration): replace run with build and direct invocation #2270
• chore(sequencer_node): replace run node shell command #2266
• chore(sequencer_node): compile the node, not the entire project #2265
• chore: add shell command builder #2264
• chore(infra): add project dir path fn #2255
• chore(infra): canonicalize path resolution #2254 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.34%. Comparing base (e3165c4) to head (4d734eb).
Report is 572 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2254       +/-   ##
===========================================
+ Coverage   40.10%   77.34%   +37.23%     
===========================================
  Files          26      385      +359     
  Lines        1895    40296    +38401     
  Branches     1895    40296    +38401     
===========================================
+ Hits          760    31165    +30405     
- Misses       1100     6828     +5728     
- Partials       35     2303     +2268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[ArniStarkware]

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/infra_utils/src/path.rs line 17 at r1 (raw file):

    #[error(transparent)]
    IoError(#[from] std::io::Error),
}

Should we delete this error variant and use std::io::Error as IOError throughout?

Code quote:

#[derive(Debug, Error)]
pub enum PathResolutionError {
    /// This error is raised when the file path does not exist, or when a non-final component in a
    /// path is not a directory. See [`std::fs::canonicalize`] for more information.
    #[error(transparent)]
    IoError(#[from] std::io::Error),
}

---

crates/infra_utils/src/path_test.rs line 3 at r1 (raw file):

use crate::path::{path_of_project_root, resolve_project_relative_path};

// TODO: Add a test for PathResolutionError::IoError.

Delete this TODO.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @ArniStarkware)

---

crates/infra_utils/src/path.rs line 17 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Should we delete this error variant and use std::io::Error as IOError throughout?

Yes. That also enabled the removal of GetPathError הי"ד.

---

crates/infra_utils/src/path_test.rs line 3 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Delete this TODO.

Done.

[github-actions]

Artifacts upload workflows:

• Started at 2024-11-25T12:38:16Z

[ArniStarkware]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/infra_utils/src/path_test.rs line 10 at r2 (raw file):

    let result = resolve_project_relative_path(relative_path);

    assert!(result.is_err(), "Expected an non-existent path error, got {:?}", result);

Or is this an overkill?

Suggestion:

assert_eq!(result.unwrap_err().display(), "File not fount", "Expected an non-existent path error, got {:?}", result);

[ArniStarkware]

Reviewed 4 of 5 files at r2, all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

[github-actions]

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [29.851 ms 29.888 ms 29.927 ms]
change: [+1.4321% +1.6171% +1.8100%] (p = 0.00 < 0.05)
Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe

[ArniStarkware]

Reviewed 1 of 5 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[Itay-Tsabary-Starkware]

✓ Commit merged in pull request #2264