-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cairo_native): temporarily revert EP gas deduction and align tests #2214
Conversation
Artifacts upload triggered. View details here |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2214 +/- ##
===========================================
+ Coverage 40.10% 68.89% +28.79%
===========================================
Files 26 109 +83
Lines 1895 13899 +12004
Branches 1895 13899 +12004
===========================================
+ Hits 760 9576 +8816
- Misses 1100 3914 +2814
- Partials 35 409 +374 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)
crates/blockifier/src/execution/native/entry_point_execution.rs
line 43 at r1 (raw file):
// Fund the initial budget since the native executor charges it before the run. // TODO(Yoni): revert once the VM is aligned with this.
This should happen after Yonatan's PR that changes the entry point's initial budget, right?
Code quote:
// TODO(Yoni): revert once the VM is aligned with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
crates/blockifier/src/execution/native/entry_point_execution.rs
line 43 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
This should happen after Yonatan's PR that changes the entry point's initial budget, right?
No, it's not related.
The VM has to charge 10K gas right before the execution. Same as native.
No description provided.