Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cairo_native): temporarily revert EP gas deduction and align tests #2214

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (e3165c4) to head (e94bdad).
Report is 537 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2214       +/-   ##
===========================================
+ Coverage   40.10%   68.89%   +28.79%     
===========================================
  Files          26      109       +83     
  Lines        1895    13899    +12004     
  Branches     1895    13899    +12004     
===========================================
+ Hits          760     9576     +8816     
- Misses       1100     3914     +2814     
- Partials       35      409      +374     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)


crates/blockifier/src/execution/native/entry_point_execution.rs line 43 at r1 (raw file):

    // Fund the initial budget since the native executor charges it before the run.
    // TODO(Yoni): revert once the VM is aligned with this.

This should happen after Yonatan's PR that changes the entry point's initial budget, right?

Code quote:

  // TODO(Yoni): revert once the VM is aligned with this.

Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)


crates/blockifier/src/execution/native/entry_point_execution.rs line 43 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

This should happen after Yonatan's PR that changes the entry point's initial budget, right?

No, it's not related.
The VM has to charge 10K gas right before the execution. Same as native.

@Yoni-Starkware Yoni-Starkware merged commit 4f06698 into main Nov 21, 2024
12 checks passed
@Yoni-Starkware Yoni-Starkware deleted the yoni/native/fix-gas-diff-temp branch November 21, 2024 10:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants