refactor(blockifier): fix some u128 gas cost remainings #2204
Conversation
|
This change is |
|
Artifacts upload triggered. View details here |
meship-starkware
changed the title
|
Artifacts upload triggered. View details here |
meship-starkware
force-pushed
the
meship/fix_some_leftovers_form_u128_gas_cost
branch
from
c45a73d to
8b3a648
Compare
|
Artifacts upload triggered. View details here |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
===========================================
+ Coverage 40.10% 68.89% +28.79%
===========================================
Files 26 109 +83
Lines 1895 13899 +12004
Branches 1895 13899 +12004
===========================================
+ Hits 760 9576 +8816
- Misses 1100 3914 +2814
- Partials 35 409 +374 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @Yoni-Starkware)
crates/blockifier/src/fee/receipt_test.rs line 435 at r1 (raw file):
&tx_execution_info.execute_call_info.expect("Execution call info should exist."); let execution_summary = CallInfo::summarize_many(vec![execution_call_info].into_iter(), &versioned_constants);
This line conflicts with dori's PR #2122
Code quote:
CallInfo::summarize_many(vec![execution_call_info].into_iter(), &versioned_constants);
There was a problem hiding this comment.
Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
meship-starkware
force-pushed
the
meship/fix_some_leftovers_form_u128_gas_cost
branch
from
8b3a648 to
a4e3ef4
Compare
|
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
Yoni-Starkware
deleted the
meship/fix_some_leftovers_form_u128_gas_cost
branch
No description provided.