Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier_reexecution): remove redundant cli commands #2201

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

aner-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.93%. Comparing base (e3165c4) to head (dae5d9e).
Report is 533 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier_reexecution/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2201      +/-   ##
==========================================
+ Coverage   40.10%   41.93%   +1.82%     
==========================================
  Files          26      204     +178     
  Lines        1895    23799   +21904     
  Branches     1895    23799   +21904     
==========================================
+ Hits          760     9980    +9220     
- Misses       1100    13354   +12254     
- Partials       35      465     +430     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@aner-starkware aner-starkware merged commit 70043b0 into main Nov 21, 2024
10 checks passed
@aner-starkware aner-starkware deleted the aner/remove_redundant_cli_commands branch November 21, 2024 09:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants