-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockifier): update cairo native version to v0.2.3 #2190
Conversation
Artifacts upload triggered. View details here |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2190 +/- ##
===========================================
+ Coverage 40.10% 77.46% +37.35%
===========================================
Files 26 385 +359
Lines 1895 40472 +38577
Branches 1895 40472 +38577
===========================================
+ Hits 760 31351 +30591
- Misses 1100 6813 +5713
- Partials 35 2308 +2273 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @varex83)
crates/starknet_sierra_compile/build.rs
line 41 at r1 (raw file):
// Set the runtime library path. This is required for Cairo native compilation. let runtime_library_path = repo_root_dir() .join("crates/blockifier/cairo_native/target/release/libcairo_native_runtime.a");
Why did the path change?
Code quote:
.join("crates/blockifier/cairo_native/target/release/libcairo_native_runtime.a");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @varex83)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @varex83)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)
No description provided.