Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace impl From<&Path> with an ad-hoc method #219

Closed
wants to merge 2 commits into from

Conversation

tdelabro
Copy link

@tdelabro tdelabro commented Jul 31, 2024

fixes: starkware-libs/blockifier#1756


This change is Reviewable

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @tdelabro)

a discussion (no related file):
Please change all the places that use the try from trait of versioned constants to use that new function


@tdelabro
Copy link
Author

@meship-starkware done

@tdelabro tdelabro force-pushed the remove-from-path-impl branch from dd94ad6 to 58ae35c Compare August 20, 2024 00:17
Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tdelabro)

Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 22, 2024
Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tdelabro)

@meship-starkware
Copy link
Contributor

@tdelabro tdelabro deleted the remove-from-path-impl branch September 25, 2024 08:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TryFrom<&Path> should not be used
2 participants