feat(blockifier): charge for inner events by VC check #2123
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
This change is |
|
Artifacts upload triggered. View details here |
dorimedini-starkware
force-pushed
the
11-17-refactor_blockifier_inject_vc_into_callinfo_summarize
branch
from
179fe8c to
a9e2006
Compare
dorimedini-starkware
force-pushed
the
11-17-feat_blockifier_charge_for_inner_events_by_vc_check
branch
from
6a9b96c to
18d2ecd
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 9 files reviewed, all discussions resolved
a discussion (no related file):
py side
|
Artifacts upload triggered. View details here |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2123 +/- ##
===========================================
+ Coverage 40.10% 69.35% +29.24%
===========================================
Files 26 108 +82
Lines 1895 13989 +12094
Branches 1895 13989 +12094
===========================================
+ Hits 760 9702 +8942
- Misses 1100 3877 +2777
- Partials 35 410 +375 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
dorimedini-starkware
requested review from
Yoni-Starkware and
aner-starkware
dorimedini-starkware
force-pushed
the
11-17-feat_blockifier_charge_for_inner_events_by_vc_check
branch
from
18d2ecd to
0e8d278
Compare
|
Artifacts upload triggered. View details here |
dorimedini-starkware
force-pushed
the
11-17-refactor_blockifier_inject_vc_into_callinfo_summarize
branch
from
a9e2006 to
d525dc2
Compare
dorimedini-starkware
force-pushed
the
11-17-feat_blockifier_charge_for_inner_events_by_vc_check
branch
from
0e8d278 to
91fc715
Compare
|
Artifacts upload triggered. View details here |
dorimedini-starkware
changed the base branch from
11-17-refactor_blockifier_inject_vc_into_callinfo_summarize
to
graphite-base/2123
|
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)
crates/blockifier/resources/versioned_constants_0_13_0.json line 11 at r3 (raw file):
"disable_cairo0_redeclaration": false, "enable_stateful_compression": false, "ignore_inner_events_resources": false,
Suggestion:
"ignore_inner_event_resources"
There was a problem hiding this comment.
Reviewed 8 of 9 files at r3.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)
There was a problem hiding this comment.
Reviewed 8 of 9 files at r3.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)
dorimedini-starkware
force-pushed
the
11-17-feat_blockifier_charge_for_inner_events_by_vc_check
branch
from
91fc715 to
6992972
Compare
dorimedini-starkware
force-pushed
the
graphite-base/2123
branch
from
d525dc2 to
510321b
Compare
|
Artifacts upload triggered. View details here |
dorimedini-starkware
changed the base branch from
graphite-base/2123
to
main
dorimedini-starkware
force-pushed
the
11-17-feat_blockifier_charge_for_inner_events_by_vc_check
branch
from
6992972 to
dece440
Compare
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
dorimedini-starkware
force-pushed
the
11-17-feat_blockifier_charge_for_inner_events_by_vc_check
branch
from
dece440 to
e9b5939
Compare
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
dorimedini-starkware
force-pushed
the
11-17-feat_blockifier_charge_for_inner_events_by_vc_check
branch
from
e9b5939 to
21f9cb2
Compare
|
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Reviewed 8 of 9 files at r3, 8 of 8 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)
No description provided.