fix(ci): make upload artifacts job edit the comment #2054

dorimedini-starkware · 2024-11-14T09:58:56Z

No description provided.

reviewable-StarkWare · 2024-11-14T09:59:03Z

This change is

github-actions · 2024-11-14T09:59:22Z

Artifacts upload triggered. View details here

github-actions · 2024-11-14T10:00:06Z

Artifacts upload triggered. View details here

.github/workflows/upload_artifacts_workflow.yml

crates/blockifier/src/test_utils/struct_impls.rs

codecov · 2024-11-14T10:07:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (e3165c4) to head (b76593b).
Report is 539 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2054       +/-   ##
===========================================
+ Coverage   40.10%   68.89%   +28.79%     
===========================================
  Files          26      109       +83     
  Lines        1895    13899    +12004     
  Branches     1895    13899    +12004     
===========================================
+ Hits          760     9576     +8816     
- Misses       1100     3914     +2814     
- Partials       35      409      +374

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

dorimedini-starkware

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @graphite-app[bot])

.github/workflows/upload_artifacts_workflow.yml

github-actions · 2024-11-14T10:10:02Z

Artifacts upload triggered. View details here

github-actions · 2024-11-20T14:43:54Z

Artifacts upload triggered. View details here

github-actions · 2024-11-20T14:48:31Z

Artifacts upload triggered. View details here

github-actions · 2024-11-20T14:52:33Z

Artifacts upload triggered. View details here

github-actions · 2024-11-20T14:56:55Z

Artifacts upload triggered. View details here

github-actions · 2024-11-20T14:59:54Z

Artifacts upload triggered. View details here

github-actions · 2024-11-20T15:05:55Z

Artifacts upload triggered. View details here

dorimedini-starkware

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @graphite-app[bot])

crates/blockifier/src/test_utils/struct_impls.rs

github-actions · 2024-11-20T15:12:11Z

Artifacts upload triggered. View details here

github-actions · 2024-11-20T15:24:54Z

Artifacts upload triggered. View details here

github-actions · 2024-11-20T15:38:13Z

Artifacts upload workflows:

github-actions · 2024-11-20T15:39:36Z

Artifacts upload workflows:

2024-11-20T15:12:20Z

github-actions · 2024-11-20T15:39:56Z

Artifacts upload triggered. View details here

github-actions · 2024-11-20T15:40:33Z

Artifacts upload triggered. View details here

github-actions · 2024-11-20T15:53:27Z

Artifacts upload triggered. View details here

github-actions · 2024-11-20T15:54:00Z

Artifacts upload triggered. View details here

github-actions · 2024-11-20T15:57:12Z

Artifacts upload triggered. View details here

github-actions · 2024-11-21T10:17:06Z

Artifacts upload triggered. View details here

dorimedini-starkware

Dismissed @graphite-app[bot] from 2 discussions.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

github-actions · 2024-11-21T10:19:20Z

Artifacts upload triggered. View details here

github-actions · 2024-11-21T11:16:00Z

Artifacts upload triggered. View details here

github-actions · 2024-11-21T11:21:27Z

Artifacts upload triggered. View details here

github-actions · 2024-11-21T11:29:14Z

Artifacts upload triggered. View details here

github-actions · 2024-11-21T11:30:53Z

Artifacts upload triggered. View details here

github-actions · 2024-11-21T11:33:02Z

Artifacts upload triggered. View details here

adi-yakovian-starkware

Reviewed 2 of 4 files at r8, 2 of 2 files at r9, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

.github/workflows/upload_artifacts_workflow.yml line 38 at r9 (raw file):

        if: env.PR_NUMBER != ''
        uses: starkware-libs/find-comment@v3
        id: fc

I prefer to avoid abbreviations, unless you have to.
It's your call, though (non-blocking), I don't know the conventions in this repo.

Suggestion:

find-comment

adi-yakovian-starkware

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware)

.github/workflows/upload_artifacts_workflow.yml line 46 at r9 (raw file):

      - name: Create comment
        if: env.PR_NUMBER != '' && steps.fc.outputs.comment-id == ''

Please document, can be done in another PR if you prefer.

Code quote:

if: env.PR_NUMBER != '' && steps.fc.outputs.comment-id == ''

.github/workflows/upload_artifacts_workflow.yml line 56 at r9 (raw file):

      - name: Update comment
        if: env.PR_NUMBER != '' && steps.fc.outputs.comment-id != ''

Same here.

Code quote:

if: env.PR_NUMBER != '' && steps.fc.outputs.comment-id != ''

Signed-off-by: Dori Medini <[email protected]>

github-actions · 2024-11-24T10:28:07Z

Artifacts upload triggered. View details here

adi-yakovian-starkware

Reviewed 1 of 1 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

adi-yakovian-starkware

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

dorimedini-starkware self-assigned this Nov 14, 2024

graphite-app bot reviewed Nov 14, 2024

View reviewed changes

.github/workflows/upload_artifacts_workflow.yml Outdated Show resolved Hide resolved

crates/blockifier/src/test_utils/struct_impls.rs Outdated Show resolved Hide resolved

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from b8d42f2 to f250d76 Compare November 14, 2024 10:09

dorimedini-starkware commented Nov 14, 2024

View reviewed changes

.github/workflows/upload_artifacts_workflow.yml Outdated Show resolved Hide resolved

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from f250d76 to 56dd7ee Compare November 20, 2024 14:41

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from 56dd7ee to 0137a13 Compare November 20, 2024 14:48

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from 0137a13 to 70037d4 Compare November 20, 2024 14:51

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from 70037d4 to 6389e82 Compare November 20, 2024 14:56

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from 4300238 to c202c85 Compare November 20, 2024 15:05

dorimedini-starkware commented Nov 20, 2024

View reviewed changes

crates/blockifier/src/test_utils/struct_impls.rs Outdated Show resolved Hide resolved

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from c202c85 to e12ac45 Compare November 20, 2024 15:10

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from d082564 to 9f69975 Compare November 20, 2024 15:37

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from 9f69975 to 926778c Compare November 20, 2024 15:39

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from 252d590 to b51e312 Compare November 20, 2024 15:53

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from 01268cd to 82ca105 Compare November 21, 2024 10:15

dorimedini-starkware commented Nov 21, 2024

View reviewed changes

dorimedini-starkware requested a review from adi-yakovian-starkware November 21, 2024 10:18

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from 82ca105 to 24568f1 Compare November 21, 2024 10:18

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from 24568f1 to 13ef706 Compare November 21, 2024 11:02

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from 3384291 to b76593b Compare November 21, 2024 11:19

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from b76593b to d71c6d9 Compare November 21, 2024 11:28

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from d71c6d9 to 296cb89 Compare November 21, 2024 11:30

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from 296cb89 to 94928f3 Compare November 21, 2024 11:32

adi-yakovian-starkware reviewed Nov 24, 2024

View reviewed changes

adi-yakovian-starkware approved these changes Nov 24, 2024

View reviewed changes

fix(ci): make upload artifacts job edit the comment

f260452

Signed-off-by: Dori Medini <[email protected]>

dorimedini-starkware force-pushed the dori/upload-artifacts-edit-comment branch from 94928f3 to f260452 Compare November 24, 2024 10:27

adi-yakovian-starkware approved these changes Nov 24, 2024

View reviewed changes

dorimedini-starkware requested a review from adi-yakovian-starkware November 24, 2024 11:35

adi-yakovian-starkware approved these changes Nov 24, 2024

View reviewed changes

dorimedini-starkware merged commit 2a5be50 into main Nov 24, 2024
10 checks passed

github-actions bot locked and limited conversation to collaborators Nov 26, 2024

fix(ci): make upload artifacts job edit the comment #2054

fix(ci): make upload artifacts job edit the comment #2054

Conversation

dorimedini-starkware commented Nov 14, 2024

reviewable-StarkWare commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

codecov bot commented Nov 14, 2024 • edited Loading

Codecov Report

dorimedini-starkware left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

dorimedini-starkware left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024 • edited Loading

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 21, 2024

dorimedini-starkware left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

adi-yakovian-starkware left a comment

Choose a reason for hiding this comment

adi-yakovian-starkware left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 24, 2024

adi-yakovian-starkware left a comment

Choose a reason for hiding this comment

adi-yakovian-starkware left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 14, 2024 •

edited

Loading

github-actions bot commented Nov 20, 2024 •

edited

Loading