Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cairo_native): add git submodule update to dependencies #2012

Closed
wants to merge 1 commit into from
Closed

chore(cairo_native): add git submodule update to dependencies #2012

wants to merge 1 commit into from

Conversation

avi-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@avi-starkware avi-starkware force-pushed the avi/cairo-native-git-submodule-command branch from 32ec9e5 to 0d2c374 Compare November 13, 2024 10:52
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

meship-starkware
meship-starkware reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @noaov1 and @Yoni-Starkware)

meship-starkware
meship-starkware approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @Yoni-Starkware)

Yoni-Starkware
Yoni-Starkware approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

@avi-starkware
Copy link
Contributor Author

This change does not go through the CI, and does not solve the problem.
A different solution is found in #2166.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meship-starkware meship-starkware meship-starkware approved these changes

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

@noaov1 noaov1 Awaiting requested review from noaov1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avi-starkware @reviewable-StarkWare @Yoni-Starkware @meship-starkware