Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add overrides to statful tx validator config #1965

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 26.08696% with 17 lines in your changes missing coverage. Please review.

Project coverage is 44.68%. Comparing base (d630be9) to head (4c47538).

Files with missing lines Patch % Lines
crates/gateway/src/config.rs 23.80% 16 Missing ⚠️
crates/blockifier/src/versioned_constants.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                         Coverage Diff                                          @@
##           arni/blockifier/versioned-constants/remove-latest-with-overrides    #1965      +/-   ##
====================================================================================================
+ Coverage                                                             44.67%   44.68%   +0.01%     
====================================================================================================
  Files                                                                   196      196              
  Lines                                                                 23558    23552       -6     
  Branches                                                              23558    23552       -6     
====================================================================================================
  Hits                                                                  10524    10524              
+ Misses                                                                12557    12551       -6     
  Partials                                                                477      477              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/blockifier/versioned-constants/remove-latest-with-overrides branch 2 times, most recently from 4fa0280 to d630be9 Compare November 12, 2024 07:55
@ArniStarkware ArniStarkware force-pushed the arni/blockifier/versioned-constants/stateful_validator_config branch from ea49a1f to 4c47538 Compare November 12, 2024 07:55
Copy link

Artifacts upload triggered. View details here

@yair-starkware
Copy link
Contributor

Doesn't this PR the same as https://reviewable.io/reviews/starkware-libs/sequencer/1946#-?

@ArniStarkware
Copy link
Contributor Author

Covered by #1946.

@ArniStarkware ArniStarkware deleted the arni/blockifier/versioned-constants/stateful_validator_config branch November 12, 2024 14:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants