chore(blockifier): verify local cairo repo state before compiling

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• feat(blockifier): recompile Cairo1 in the CI #197
• chore(blockifier): add is_legacy method #196
• chore(blockifier): add text file with current compiler version for CI use #195
• chore(blockifier): verify local cairo repo state before compiling #194 👈
• feat(blockifier): support Cairo1 local recompilation #184
• chore(blockifier): verify cairo compiler repo (with correct tag) #183
• feat(blockifier): verify cairo-lang version before Cairo0 compilation #182
• chore(blockifier): fetch compiler repo version #181
• chore(blockifier): move contract compilation logic to separate module + contracts.rs #180
• chore(blockifier): refactor feature contract path getters for different paths #179
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[TzahiTaub]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @nimrod-starkware)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 183 at r4 (raw file):

        "Cannot verify Cairo1 contracts, Cairo repo not found at {0}.\n\
        Please run:\n\
        git clone https://github.com/starkware-libs/cairo {0} && git -C {0} checkout {1}\n\

The script checkout in the next stage, I think this can be removed

---

crates/blockifier/src/test_utils/cairo_compile.rs line 205 at r4 (raw file):

        "--verify",
        &tag,
    ]));

What does this add to the previous action (I mean, if the tag doesn't exist, we will fail in the checkout stage)?

Code quote:

    // Verify that the checked out tag is as expected.
    run_and_verify_output(Command::new("git").args([
        "-C",
        cairo_repo_path.to_str().unwrap(),
        "rev-parse",
        "--verify",
        &tag,
    ]));

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, @nimrod-starkware, and @TzahiTaub)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 205 at r4 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

What does this add to the previous action (I mean, if the tag doesn't exist, we will fail in the checkout stage)?

in case we somehow "silently" fail the checkout and not catch the error.
may be redundant, but when we parallelize this test (takes forever to sequencially compile all contracts...) it will be useful to split checkout / verify checkout phases anyway

[TzahiTaub]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @nimrod-starkware)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 205 at r4 (raw file):

Previously, dorimedini-starkware wrote…

in case we somehow "silently" fail the checkout and not catch the error.
may be redundant, but when we parallelize this test (takes forever to sequencially compile all contracts...) it will be useful to split checkout / verify checkout phases anyway

Can't say I understand (to parallelize I assume you need to run different tag compilation sequentially and parallelize only contracts using the same tag. In this case you can make one checkout, parallel compilations, and when finished - new checkout, (parallel) compilation etc. Don't see where the verify helps here. But unblocking

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @nimrod-starkware)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 205 at r4 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Can't say I understand (to parallelize I assume you need to run different tag compilation sequentially and parallelize only contracts using the same tag. In this case you can make one checkout, parallel compilations, and when finished - new checkout, (parallel) compilation etc. Don't see where the verify helps here. But unblocking

exactly.
I can checkout once, and verify in every thread

[dorimedini-starkware]

Merge activity

• Aug 11, 11:28 AM EDT: @dorimedini-starkware started a stack merge that includes this pull request via Graphite.
• Aug 11, 12:25 PM EDT: Graphite rebased this pull request as part of a merge.
• Aug 11, 12:32 PM EDT: @dorimedini-starkware merged this pull request with Graphite.