chore(blockifier): add sierra to storage w append_block

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 9.38%. Comparing base (e3165c4) to head (509590f).
Report is 317 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/native_blockifier/src/storage.rs	75.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #1773       +/-   ##
==========================================
- Coverage   40.10%   9.38%   -30.72%     
==========================================
  Files          26     132      +106     
  Lines        1895   17246    +15351     
  Branches     1895   17246    +15351     
==========================================
+ Hits          760    1619      +859     
- Misses       1100   15303    +14203     
- Partials       35     324      +289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[avi-starkware]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @noaov1)

---

crates/native_blockifier/src/storage.rs line 170 at r1 (raw file):

        let mut declared_classes = IndexMap::<ClassHash, (CompiledClassHash, ContractClass)>::new();
        let mut undeclared_casm_contracts = Vec::<(ClassHash, CasmContractClass)>::new();
        for (class_hash, (sierra, (compiled_class_hash, raw_class))) in declared_class_hash_to_class

Suggestion:

for (class_hash, (raw_sierra, (compiled_class_hash, raw_casm))) in declared_class_hash_to_class

[avivg-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1)

---

crates/native_blockifier/src/storage.rs line 170 at r1 (raw file):

        let mut declared_classes = IndexMap::<ClassHash, (CompiledClassHash, ContractClass)>::new();
        let mut undeclared_casm_contracts = Vec::<(ClassHash, CasmContractClass)>::new();
        for (class_hash, (sierra, (compiled_class_hash, raw_class))) in declared_class_hash_to_class

Done.

[github-actions]

Artifacts upload triggered. View details here

[avi-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[github-actions]

Artifacts upload triggered. View details here

[avi-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[avi-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[noaov1]

Reviewed 3 of 4 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

---

crates/native_blockifier/src/storage.rs line 300 at r3 (raw file):

        previous_block_id: Option<PyFelt>,
        py_block_info: PyBlockInfo,
        py_state_diff: PyStateDiff,

Consider defining a type (same for deprecated_declared_class_hash_to_class):

Code snippet:

// Class hash to (raw_sierra, (compiled class hash, raw casm)).
type RawDeclaredClassMapping = HashMap<PyFelt, (String, (PyFelt, String))

[github-actions]

Artifacts upload triggered. View details here

[avivg-starkware]

• chore(blockifier): add sierra to storage w append_block #1773 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @avivg-starkware and the rest of your teammates on Graphite

[github-actions]

Artifacts upload triggered. View details here

[avivg-starkware]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1)

---

crates/native_blockifier/src/storage.rs line 300 at r3 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Consider defining a type (same for deprecated_declared_class_hash_to_class):

Added :)

[github-actions]

Artifacts upload triggered. View details here

[avivg-starkware]

Reviewed 1 of 2 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)