Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono repo final sync #17

Merged
merged 29 commits into from
Jul 18, 2024
Merged

mono repo final sync #17

merged 29 commits into from
Jul 18, 2024

Conversation

dafnamatsry
Copy link
Collaborator

@dafnamatsry dafnamatsry commented Jul 16, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 216 lines in your changes missing coverage. Please review.

Project coverage is 76.90%. Comparing base (d852e75) to head (d925f54).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/native_blockifier/src/py_validator.rs 0.00% 26 Missing ⚠️
crates/papyrus_node/src/main.rs 13.79% 23 Missing and 2 partials ⚠️
...s/blockifier/src/test_utils/transfers_generator.rs 78.87% 15 Missing ⚠️
crates/starknet_api/src/transaction.rs 0.00% 14 Missing and 1 partial ⚠️
...papyrus_network/src/network_manager/swarm_trait.rs 0.00% 14 Missing ⚠️
crates/papyrus_p2p_sync/src/lib.rs 0.00% 12 Missing ⚠️
crates/mempool/src/transaction_pool.rs 31.25% 11 Missing ⚠️
crates/mempool/src/transaction_queue.rs 23.07% 10 Missing ⚠️
crates/gateway/src/compilation.rs 81.81% 5 Missing and 3 partials ⚠️
...papyrus_consensus/src/papyrus_consensus_context.rs 56.25% 3 Missing and 4 partials ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   76.85%   76.90%   +0.05%     
==========================================
  Files         263      267       +4     
  Lines       31672    31923     +251     
  Branches    31672    31923     +251     
==========================================
+ Hits        24340    24550     +210     
- Misses       5136     5179      +43     
+ Partials     2196     2194       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafnamatsry dafnamatsry changed the title Dafna/the mono repo mono repo final sync Jul 16, 2024
@dafnamatsry dafnamatsry force-pushed the dafna/the-mono-repo branch from f4953a4 to d4e2454 Compare July 16, 2024 11:35
@dafnamatsry dafnamatsry force-pushed the dafna/the-mono-repo branch from 7f3203b to 11dee1e Compare July 17, 2024 11:17
@dafnamatsry dafnamatsry force-pushed the dafna/the-mono-repo branch from 11dee1e to da38d70 Compare July 17, 2024 11:20
@dafnamatsry dafnamatsry force-pushed the dafna/the-mono-repo branch from da38d70 to cb68c32 Compare July 17, 2024 11:28
@dafnamatsry dafnamatsry force-pushed the dafna/the-mono-repo branch from cb68c32 to 43441c8 Compare July 17, 2024 11:53
@alon-dotan-starkware alon-dotan-starkware force-pushed the dafna/the-mono-repo branch 6 times, most recently from 2d5a409 to 4a96190 Compare July 17, 2024 13:12
@alon-dotan-starkware alon-dotan-starkware merged commit e16fff4 into main Jul 18, 2024
19 of 23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants