refactor(blockifier): revert change to VersionedConstantsOverrides #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Artifacts upload triggered. View details here |
ayeletstarkware
force-pushed
the
ayelet/blockifier/versioned-constants-overiddes/revert
branch
from
eca24f6 to
08d89b8
Compare
|
Artifacts upload triggered. View details here |
ayeletstarkware
changed the title
|
Artifacts upload triggered. View details here |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1572 +/- ##
==========================================
+ Coverage 40.10% 46.75% +6.64%
==========================================
Files 26 210 +184
Lines 1895 24663 +22768
Branches 1895 24663 +22768
==========================================
+ Hits 760 11530 +10770
- Misses 1100 12347 +11247
- Partials 35 786 +751 ☔ View full report in Codecov by Sentry. |
This reverts commit 451a444.
ayeletstarkware
force-pushed
the
ayelet/blockifier/versioned-constants-overiddes/revert
branch
from
08d89b8 to
1c116f3
Compare
|
Artifacts upload triggered. View details here |
ArniStarkware
approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 451a444.